Remove hard coded pip show in fix_direct_url
#2352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before uv 0.4.25, `uv pip show` did not support the `--files` argument which is required by `fix_direct_url`. Now that the flag is supported, falling back to pip is not necessary. Error handling is also improved. Previously if pip was not present in the environment (which is the case for `uv venv`) no error was reported to the user but `fix_direct_url` will have failed so the package is not installed in editable mode.
|
not sure why the |
mbway
commented
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before uv 0.4.25,
uv pip showdid not support the--filesargument which is required byfix_direct_url. Now that the flag is supported, falling back to pip is not necessary.Error handling is also improved. Previously if pip was not present in the environment (which is the case for
uv venv) no error was reported to the user butfix_direct_urlwill have failed so the package is not installed in editable mode.fixes #2346